Standardize config schema terminology from 'children' to 'entries' #6435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates all schema-related code and documentation to consistently use 'entries' instead of 'children' for config scope components. The term 'entries' better reflects the nature of these elements as key-value pairs in a configuration map, rather than hierarchical child nodes. This terminology is more aligned with standard configuration and data structure conventions. Changes include: - SchemaNode.java: Updated variable names and record field from children to entries - ConfigValidator.groovy: Updated variable names and method calls - ConfigSpec.groovy: Updated variable names and output field names - PluginSpecTest.groovy: Updated test expectations to use entries field - ADR documentation: Updated terminology in plugin spec documentation - MarkdownRenderer.groovy: Updated method calls to use entries() 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Merged
bentsherman
requested changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
The term 'entries' better reflects the nature of these elements as key-value pairs in a configuration map, rather than hierarchical child nodes. This terminology is more aligned with standard configuration and data structure conventions (similar to Map.entrySet(), dictionary entries, etc.).
Changes Made
childrentoentriesentries()entriesfieldentries()Test Plan
🤖 Generated with Claude Code
Note
Renames the config schema map field and accessors from
children/getChildtoentries/getEntry, updating validators, renderers, spec generation, tests, and ADR docs.SchemaNode.Scope.childrentoentries; update constructors and usage inROOT,processScope(), andScope.of(...).Scope.getChild(...)togetEntry(...); adjustgetDslOption,getOption,getScopeto use it.nextflow/config/ConfigValidator.groovy):childrentoentries; useROOT.getEntry(...)andscope.entries().config/schema/MarkdownRenderer.groovy):children()traversals withentries()for options/scopes recursion.plugin/spec/ConfigSpec.groovy):entriesinstead ofchildrenin generated spec JSON.PluginSpecTest.groovy):entriesarray.adrs/2025-09-22-plugin-spec.md):childrenwithentriesin spec description and examples.Written by Cursor Bugbot for commit 64fb43d. This will update automatically on new commits. Configure here.